Re: [Tails-dev] [review'n'merge:1.2] test/7231-uefi-boot

26/08/14 01:36, intrigeri wrote:
> hi,
>
> test/7231-uefi-boot (#7231) adds an automated test of UEFI boot.
> It should be merged into devel *after* the branch that's about #7173.

commit 6568230b77431355dfac04865243f267f6319c0a
+Given /^the computer is set to boot in UEFI mode$/ do
+ next if @skip_steps_while_restoring_background
+ @vm.set_os_loader('UEFI')
+ @os_loader = 'UEFI'
+end

The variable `@os_loader` will be reset to 'MBR' before each scenario,
so if it would be part of the background, then its value will only be
set for the first scenario post-background since it will be skipped in
subsequent scenarios. This is another unfortunate instance of #5847.
This is not an issue in the way it's used currently, but it could result
in confusion later. Hence I think I recommend doing either of the
following two:

* set `@os_loader` before the `next if ...` line, like in the "I set
sudo password ..." step, or
* switch to a global variable.

Otherwise it looks good, so I've merged the branch into devel. I will
accept any fixes for the above issue post-freeze.

Cheers!