Re: [Tails-dev] [review'n'merge 1.1.1] Tails Installer shoul…

Delete this message

Reply to this message
Author: intrigeri
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] [review'n'merge 1.1.1] Tails Installer should not run update_system_partition_properties on MBR partitions.
Hi,

Andres Gomez Ramirez wrote (07 Aug 2014 22:15:53 GMT) :
> Since I don't have yet a repository for liveusb-creator, I'm sending
> this single patch.
> Ticket: https://labs.riseup.net/code/issues/7716.


Thanks!

I'm surprised we have to go through this:

+        if re.match( r'^[0-9A-F]{8}(-[0-9A-F]{4}){3}-[0-9A-F]{12}$', partition_type):


... to check if the device to be upgraded has a GPT.

Can't we instead use the "PartitionTableScheme" property of the
parent device? This would seem more straightforward to me:
http://udisks.freedesktop.org/docs/1.0.5/Device.html#Device:PartitionTableScheme

Cheers,
--
intrigeri