Re: [Tails-dev] Tails build broken?

Delete this message

Reply to this message
Author: intrigeri
Date:  
To: Robert Heller
CC: The Tails public development discussion list
Subject: Re: [Tails-dev] Tails build broken?
Hi,

(do you read the list, or shall we go on Cc'ing you?)

Robert Heller wrote (19 Feb 2014 15:18:27 GMT) :
> I am on 64-bit Debian 7.4 with rake 0.9.2.2-4, vagrant 1.0.3-1 and virtualbox
> 4.1.18-dfsg-2+deb7u1 and after a fresh download of the tails build I get this
> error:


> ** Invoke build (first_time)
> ** Invoke parse_build_options (first_time)
> ** Execute parse_build_options
> rake aborted!
> cannot load such file -- vagrant/util/downloader

[...]
> What is going on here?


Short version: our Vagrant build system was broken for months with
recent Vagrant's, and many people complained; someone proposed patches
that fixed this; someone else confirmed it worked for them too; nobody
ever answered the calls for testing the patches against Debian
Wheezy's Vagrant 1.0.3; after a while, we merged the patches. And we
now discover that the build is broken on Wheezy.

The "require 'vagrant/util/downloader'" stance was added in commit
cf54ba1b. Debian sid's Vagrant 1.4.3 indeed ships
/usr/lib/ruby/vendor_ruby/vagrant/util/downloader.rb. Debian Wheezy's
1.0.3 does not.

Later in the affected file (vagrant/lib/tails_build_settings.rb),
I see a conditional part depending on the Vagrant version. Might it be
that this small patch fixes this problem for you?

--- a/vagrant/lib/vagrant_verified_download.rb
+++ b/vagrant/lib/vagrant_verified_download.rb
@@ -1,5 +1,4 @@
require 'digest'
-require 'vagrant/util/downloader'
require 'vagrant/errors'

 def check(path)
@@ -19,6 +18,7 @@ module Vagrant
       end
     end
   else
+    require 'vagrant/util/downloader'
     class Util::Downloader
       alias :unverified_download! :download!
       def download!


Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc