Re: [Tails-dev] Please review and merge feature/about_tails

Slet denne besked

Besvar denne besked
Skribent: intrigeri
Dato:  
Til: The Tails public development discussion list
Emne: Re: [Tails-dev] Please review and merge feature/about_tails
Hi,

> tails_version = subprocess.Popen(["tails-version"], stdout=subprocess.PIPE).communicate()[0]


I guess this is probably not a blocker, but does this throw an
exception if `tails-version' fails for some reason, or does it fail
and goes on more or less silently?

Otherwise, looks good to me, congrats! I'm happy to test and merge
once the history is cleaned up. Retagging the ticket accordingly.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc